On 10/30/07, Nick Kossifidis <mickflemm@xxxxxxxxx> wrote: > 2007/10/30, Ulrich Meis <meis@xxxxxxxxxxxxxxxxxxx>: > > On Tue 30.10.07 12:45, Luis R. Rodriguez wrote: > > > On 10/27/07, Nick Kossifidis <mick@xxxxxxxxxxx> wrote: > > > > fill_tx_desc is used for fast frames operation, since > > > > we don't support fast frames (and since fill_tx_desc > > > > had a bug -thanx to Ulrich Meis for finding that out-) > > > > these functions are not needed (+ they are misleading > > > > because they don't "fill" any tx descriptor). > > > > > > > > I couldn't test this patch much so plz someone ACK it... > > > > > > > > It applies on top of my previous patches (i just thought > > > > that [PATCH 8/7] won't look nice ;-) ). > > > > > > > > > > > > Changes-licensed-under: ISC > > > > Signed-off-by: Ulrich Meis <meis@xxxxxxxxxxxxxxxxxxx> > > > > Signed-Off-by: Nick Kossifidis <mickflemm@xxxxxxxxx> > > > > > > Very nice, I've been testing this on 2.6.24-rc1 for a day without > > > problems. I'll soon post results of of all your patches and your 1-7 > > > series on big endian. Compiling takes a while there, heh.. I guess I > > > should be cross compiling huh. > > > > People using the 5212 need the line below though if they wanna be able > > to sent out frames :) It's missing in the 4word version. Besides that > > the patches also seem to run fine here. > > > > Uli > > > > Ouch, i've missed this, thanx for finding out ;-) > > > + tx_desc->tx_control_1 = buff_len & AR5K_2W_TX_DESC_CTL1_BUF_LEN; > > + > > 2W_TX_DESC -> define for 2word descriptor (check out hw.h) just to > maintain naming > scheme, i suggest we use the 4W_TX_DESC define (they are the same > values but it's better for code readability). > > tx_desc->tx_control_1 = buff_len & AR5K_4W_TX_DESC_CTL1_BUF_LEN; > > can you plz repost the patch as a separate thread (check out > http://www.linuxwireless.org/en/developers/SubmittingPatches) ? IMO you should have just sent a patch as your patch really does break AR5212 TX but whatever works with John. Anyway, just a pointer to John -- hunk 3 on hw.c will fail here but its not important its just a redundant hunk. Luis - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
