Search Linux Wireless

Re: [ipw3945-devel] iwl3945 lists supported rates backwards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This might break rate scaling for 3945 adapter. I look into rearrange the rate and do what ever needed to make rate scaling wont break.
Mohamed
dragoran wrote:
On 10/29/07, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
--- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
+++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
@@ -5414,10 +5414,10 @@ static int iwl_init_geos(struct iwl_priv *priv)
       * is supported by a mode -- and the first match is taken
       */

-     if (modes[G].num_channels)
-             ieee80211_register_hwmode(priv->hw, &modes[G]);
      if (modes[B].num_channels)
              ieee80211_register_hwmode(priv->hw, &modes[B]);
+     if (modes[G].num_channels)
+             ieee80211_register_hwmode(priv->hw, &modes[G]);
      if (modes[A].num_channels)
              ieee80211_register_hwmode(priv->hw, &modes[A]);
Huh no, you misunderstood my mail.

This makes mac80211 always select 802.11B mode which is not what you
want. You want to change the order of rates within the G mode.


shouldn't this one do it?
 (untested)

---
diff --git a/origin/iwl-3945-rs.h b/origin/iwl-3945-rs.h
index 09fa1a7..18b19a2 100644
--- a/origin/iwl-3945-rs.h
+++ b/origin/iwl-3945-rs.h
@@ -39,7 +39,11 @@ struct iwl_rate_info {
 };

 enum {
-       IWL_RATE_6M_INDEX = 0,
+       IWL_RATE_1M_INDEX = 0,
+       IWL_RATE_2M_INDEX,
+       IWL_RATE_5M_INDEX,
+       IWL_RATE_11M_INDEX,
+       IWL_RATE_6M_INDEX,
        IWL_RATE_9M_INDEX,
        IWL_RATE_12M_INDEX,
        IWL_RATE_18M_INDEX,
@@ -47,10 +51,6 @@ enum {
        IWL_RATE_36M_INDEX,
        IWL_RATE_48M_INDEX,
        IWL_RATE_54M_INDEX,
-       IWL_RATE_1M_INDEX,
-       IWL_RATE_2M_INDEX,
-       IWL_RATE_5M_INDEX,
-       IWL_RATE_11M_INDEX,
        IWL_RATE_COUNT,
        IWL_RATE_INVM_INDEX,
        IWL_RATE_INVALID = IWL_RATE_INVM_INDEX

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Ipw3945-devel mailing list
Ipw3945-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/ipw3945-devel
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux