On Sun, 2007-09-30 at 13:52 +0200, Tomas Winkler wrote: > This patch adds sta_notify callback and removes sta_table_notification > which was not used by any driver. > sta_notify() is essential for drivers that keeps notion of station > internally and need to be notified about removal or addition of a station > to the (I)BSS or assocation to an AP. Looks good to me. > This version adds interface id to the parameter list > as suggested by Johannes Berg I think I created a problem with this, see below. > + if (local->ops->sta_notify) > + local->ops->sta_notify(local_to_hw(local), sta->dev->ifindex, > + STA_NOTIFY_REMOVE, sta->addr); Never thought about this before, but "dev" could be a VLAN at this point so the if index will be useless. However, since we don't have per-IF stations right now this patch is fine with me, I'll just have to remember to fix this call when I add per-IF stations and drivers might start to care. Acked-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
