On Friday 28 September 2007 13:01, Luis R. Rodriguez wrote:
> -static int zd_op_stop(struct ieee80211_hw *hw)
> +void zd_op_stop(struct ieee80211_hw *hw)
static
> + /* Only deal with supported flags */
> + changed_flags &= SUPPORTED_FIF_FLAGS;
> + *new_flags &= SUPPORTED_FIF_FLAGS;
> +
> + /* changed_flags is always populated but this driver
> + * doesn't support all FIF flags so its possible we don't
> + * need to do anything */
> + if (!changed_flags)
> + return;
> +
> + if ((*new_flags & (FIF_PROMISC_IN_BSS | FIF_ALLMULTI)) ||
> + has_monitor_interfaces(mac)) {
Inconsistent use of SUPPORTED_FIF_FLAGS vs. FIF_PROMISC_IN_BSS | FIF_ALLMULTI.
Also, mac address configuration should be moved to add_interface from the
start callback.
-Michael Wu
Attachment:
pgp7L1QQi0CJW.pgp
Description: PGP signature
