On Thursday 27 September 2007 22:54:44 Ivo van Doorn wrote:
> Hi,
>
> > @@ -2401,8 +2401,7 @@ static void b43_periodic_every1sec(struc
> > radio_hw_enable = b43_is_hw_radio_enabled(dev);
> > if (unlikely(dev->radio_hw_enable != radio_hw_enable)) {
> > dev->radio_hw_enable = radio_hw_enable;
> > - b43info(dev->wl, "Radio hardware status changed to %s\n",
> > - radio_hw_enable ? "ENABLED" : "DISABLED");
> > + b43_rfkill_toggled(dev, radio_hw_enable);
>
> Isn't it better to use the input_polldev for scheduled input device checking?
>
> > +static void b43_notify_rfkill_press(struct work_struct *work)
> > +{
> > + struct b43_rfkill *rfk = container_of(work, struct b43_rfkill,
> > + notify_work);
> > + struct b43_wl *wl = container_of(rfk, struct b43_wl, rfkill);
> > + struct b43_wldev *dev;
> > + enum rfkill_state state;
>
> Same here, input_polldev was created especially for hardware
> devices that don't trigger interrupts when the button was pressed.
Ah, well. Will change that later. This works for now.
--
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
