On Fri, 2007-09-21 at 17:52 -0400, Luis R. Rodriguez wrote: > > Then we can use "enum ieee80211_band" below in the structs and get type > > checking. Generally, no new stuff has anything to do with > > include/net/ieee80211.h, that's just for the old "stack". > > Sure, I just wanted to point out the band def existed in another > header. My hopes is we can address all common header stuff once in for > all. I guess it'll have to wait a bit more. Oh ok. But I think we should start using sane values (these bits look awfully like you could OR them which is totally bogus) and convert the other stack over. > > > + * @name: name for this subband. > > > > Why does it need a name? > > Well to distinguish it. But why do we need to distinguish subbands by name? What do we use them for anyway? > > > + * @min_freq: minimum frequency for this subband, in MHz. This represents the > > > + * center of frequency of a channel. > > > + * @max_freq: maximum frequency for this subband, in MHz. This represents the > > > + * center of frequency of a channel. > > > > How can both be center freq? > > min_freq is the center of frequency for the minimum channel on the > subband. max_freq is the center of frequency for the max channel on > the subband. I guess I should clear that up a little more huh. Uh ok, no, I just need to read better :) > > > +/** > > > + * struct ieee80211_regdomain - defines a regulatory domain > > > + * > > > + * @regdomain_id: ID of this regulatory domain. Some come from > > > + * http://standards.ieee.org/getieee802/download/802.11b-1999_Cor1-2001.pdf > > > + * @regdomain_name: name of this regulatory domain. > > > + * @list: node, part of band_restrictions_list > > > + * > > > + * This structure defines a regulatory domain, which consists of channel and > > > + * power restrictions. Some regulatory domains come from > > > + * 802.11b-1999_Cor1-2001, the rest are based on Reyk Floeter's ar5k. If > > > + * there is need to add more values here, please add one that is either > > > + * defined in a standard or that many hardware devices have adopted. Also > > > + * note that multiple countries can map to the same @regdomain_id > > > > There's no table here where you could add values, is there?. > > There is a lot of them.. but we can add few to show as an example. Then again. Why do we have this struct in a header file? > I should have explained that too. Well, if you may recall in my last > implementation of this I actually used a linked list. I then decided > we weren't going to add new 2.4GHz or 5GHz subbands unless a big > IEEE-802.11 change occurs. That doesn't happen so often to either use > linked list or a variable length array. Ok I just don't understand why you have this information in a struct. Shouldn't all of this information be essentially internal to the regulatory code, and people who use it simply query it and get back a pointer to the subband that applies to their query? I don't see why everybody needs to see this huge array. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
