There are additional sparse warnings in b43legacy. None of them result in program errors, but are fixed for completeness. Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> --- drivers/net/wireless/b43legacy/debugfs.c | 14 +++++++------- drivers/net/wireless/b43legacy/pio.c | 6 +++--- 2 files changed, 10 insertions(+), 10 deletions(-) Index: wireless-dev/drivers/net/wireless/b43legacy/debugfs.c =================================================================== --- wireless-dev.orig/drivers/net/wireless/b43legacy/debugfs.c +++ wireless-dev/drivers/net/wireless/b43legacy/debugfs.c @@ -39,7 +39,7 @@ /* The root directory. */ -struct dentry *rootdir; +static struct dentry *rootdir; struct b43legacy_debugfs_fops { ssize_t (*read)(struct b43legacy_wldev *dev, char *buf, size_t bufsize); @@ -76,7 +76,7 @@ struct b43legacy_dfs_file * fops_to_dfs_ /* wl->irq_lock is locked */ -ssize_t tsf_read_file(struct b43legacy_wldev *dev, char *buf, size_t bufsize) +static ssize_t tsf_read_file(struct b43legacy_wldev *dev, char *buf, size_t bufsize) { ssize_t count = 0; u64 tsf; @@ -90,7 +90,7 @@ ssize_t tsf_read_file(struct b43legacy_w } /* wl->irq_lock is locked */ -int tsf_write_file(struct b43legacy_wldev *dev, const char *buf, size_t count) +static int tsf_write_file(struct b43legacy_wldev *dev, const char *buf, size_t count) { u64 tsf; @@ -102,7 +102,7 @@ int tsf_write_file(struct b43legacy_wlde } /* wl->irq_lock is locked */ -ssize_t ucode_regs_read_file(struct b43legacy_wldev *dev, char *buf, size_t bufsize) +static ssize_t ucode_regs_read_file(struct b43legacy_wldev *dev, char *buf, size_t bufsize) { ssize_t count = 0; int i; @@ -116,7 +116,7 @@ ssize_t ucode_regs_read_file(struct b43l } /* wl->irq_lock is locked */ -ssize_t shm_read_file(struct b43legacy_wldev *dev, char *buf, size_t bufsize) +static ssize_t shm_read_file(struct b43legacy_wldev *dev, char *buf, size_t bufsize) { ssize_t count = 0; int i; @@ -135,7 +135,7 @@ ssize_t shm_read_file(struct b43legacy_w return count; } -ssize_t txstat_read_file(struct b43legacy_wldev *dev, char *buf, size_t bufsize) +static ssize_t txstat_read_file(struct b43legacy_wldev *dev, char *buf, size_t bufsize) { struct b43legacy_txstatus_log *log = &dev->dfsentry->txstatlog; ssize_t count = 0; @@ -183,7 +183,7 @@ out_unlock: } /* wl->irq_lock is locked */ -int restart_write_file(struct b43legacy_wldev *dev, const char *buf, size_t count) +static int restart_write_file(struct b43legacy_wldev *dev, const char *buf, size_t count) { int err = 0; Index: wireless-dev/drivers/net/wireless/b43legacy/pio.c =================================================================== --- wireless-dev.orig/drivers/net/wireless/b43legacy/pio.c +++ wireless-dev/drivers/net/wireless/b43legacy/pio.c @@ -66,7 +66,7 @@ static u16 tx_get_next_word(const u8 *tx source = packet; i -= txhdr_size; } - ret = le16_to_cpu(*((u16 *)(source + i))); + ret = le16_to_cpu(*((__le16 *)(source + i))); *pos += 2; return ret; @@ -539,7 +539,7 @@ static void pio_rx_error(struct b43legac void b43legacy_pio_rx(struct b43legacy_pioqueue *queue) { - u16 preamble[21] = { 0 }; + __le16 preamble[21] = { 0 }; struct b43legacy_rxhdr_fw3 *rxhdr; u16 tmp; u16 len; @@ -609,7 +609,7 @@ data_ready: skb_put(skb, len); for (i = 0; i < len - 1; i += 2) { tmp = b43legacy_pio_read(queue, B43legacy_PIO_RXDATA); - *((u16 *)(skb->data + i)) = cpu_to_le16(tmp); + *((__le16 *)(skb->data + i)) = cpu_to_le16(tmp); } if (len % 2) { tmp = b43legacy_pio_read(queue, B43legacy_PIO_RXDATA); - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html