On Mon, 2007-09-17 at 15:42 +0200, Tomas Winkler wrote: > + void (*sta_notify)(struct ieee80211_hw *hw, > + sta_notify_cmd cmd, const u8 *addr); I have plans to make the sta_info structs per-netdev so that we can support having the same station associate to multiple virtual APs and not hurting WDS links etc. This is not too hard, but needs some thought. However, for this callback to be correct when the same sta_info struct can be present for multiple virtual interfaces, we need to be able to distinguish somehow, so this callback should probably get an if_idx that allows a driver to map to the right interface because in add_interface it was given the same if_idx. I know this doesn't matter for iwlwifi because it only supports a single local MAC address and currently not even WDS/AP mode at the same time (nor AP mode at all? haven't checked). And I wonder if there will ever be any hardware that cares and supports the configuration that would require it. Should we just leave it and add a comment that when the driver supports multiple interfaces this callback is unusable? Thoughts? Do you have plans to, say, support combined WDS/AP modes? If so, would the firmware be able to distinguish between the same STA sending WDS frames and trying to associate? I don't know if any current software supports that but I see nothing precluding it either. Or say you have a WDS interface and also associate with a client interface to the same AP; we could easily do that with b43 by allowing WDS interfaces with the same MAC address in parallel all the time. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
