On Mon, 2007-09-10 at 13:14 +0100, Christoph Hellwig wrote: > No. Say you have the following case: > > ----------- foo.h ------------ > int foo; > ----------- foo1.c ----------- > #include "foo.h" > ----------- foo2.c ----------- > #include "foo.h" > --------- Makefile ----------- > obj-m += foo.o > foo-y += foo1.o foo2.o > > > This gives you a foo COMMON symbol. Ah, ok. I'm not familiar with these drivers though so I have no idea why this happened, and then only with -D__CHECK_ENDIAN__. > But at least on i386 the kernel > is compiled with -fno-common so you get a warning like: I'm building on powerpc. It has -fno-common as well. > I wonder how the driver build managed to override our global -fno-common > setting. No idea. I guess the driver authors should look into it :) johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
