Search Linux Wireless

Re: [RFC 2/2] mac80211: revamp interface and filter configuration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Berg wrote:
+	/*
+	 * Configure the device's RX filter.
[...]
+	 * Must be atomic due to running under the tx lock.

This is slightly freaky for zd1211rw and probably other USB drivers. In most cases we can't act upon any of those filter flag changes in atomic context.

We could defer work like we do for multicast lists, but then the driver would be lying in that it would return from configure_filter saying that it has honoured some flags without actually having done so (yet).

Will that be a problem? I'm thinking maybe not, since the flags only affect RX and we can't determine which frames will be in the air at any time. [as opposed to such atomicity problems that relate to TX, we can just disable TX until the work has completed]

+	 * This callback is must be implemented.
+	 */

Typo.

Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux