Search Linux Wireless

[PATCH 07/35] Don't use shift on numeric constants in usb_control_msg() arguments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



We don't know the meaning of 0x0a02 and 0x0902 in at76_get_hw_cfg() and
at76_get_hw_cfg_intersil() respectively, so don't pretend that we do.

Signed-off-by: Pavel Roskin <proski@xxxxxxx>
---

 drivers/net/wireless/at76_usb.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


diff --git a/drivers/net/wireless/at76_usb.c b/drivers/net/wireless/at76_usb.c
index 55e82cd..8994b70 100644
--- a/drivers/net/wireless/at76_usb.c
+++ b/drivers/net/wireless/at76_usb.c
@@ -599,7 +599,7 @@ static inline int at76_get_hw_cfg(struct usb_device *udev,
 {
 	return usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), 0x33,
 			       USB_TYPE_VENDOR | USB_DIR_IN |
-			       USB_RECIP_INTERFACE, ((0x0a << 8) | 0x02), 0,
+			       USB_RECIP_INTERFACE, 0x0a02, 0,
 			       buf, buf_size, USB_CTRL_GET_TIMEOUT);
 }
 
@@ -609,7 +609,7 @@ static inline int at76_get_hw_cfg_intersil(struct usb_device *udev,
 {
 	return usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), 0x33,
 			       USB_TYPE_VENDOR | USB_DIR_IN |
-			       USB_RECIP_INTERFACE, ((0x09 << 8) | 0x02), 0,
+			       USB_RECIP_INTERFACE, 0x0902, 0,
 			       buf, buf_size, USB_CTRL_GET_TIMEOUT);
 }
 
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux