Search Linux Wireless

Re: [PATCH] mac80211: don't send invalid QoS frames

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Oh, I see a bug.

On Thu, 2007-08-30 at 16:22 +0200, Johannes Berg wrote:

> +	if (fc & IEEE80211_STYPE_QOS_DATA) {
> +		__le16 *qos_control;
> +
> +		memcpy(skb_push(skb, hdrlen - 2), &hdr, hdrlen - 2);
> +		qos_control = (__le16*) skb_push(skb, 2);

These last two statements should be the other way around, of course.
We're pushing data into the head of the skb here, so we need to push the
QoS control field first and then the header. The way I wrote it there
the zeroed field ends up being the frame control field, indicating that
it's an association request frame. You should be seeing those as mangled
frames in wireshark though.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux