On Tue, 2007-08-28 at 17:07 +0800, Zhu Yi wrote: > Because of the difference of the two hardwares (for example, in > iwl-command.h, iwl_rxon_assoc_cmd differs between 3945 and 4965), > runtime supporting is difficult if not possible (hw structures differs). > So we select to do it statically by generating two drivers from one > source code. We used to be able to even runtime-select transmit headers in bcm43xx. > Do you think if it is a good idea to split them into two drivers and > make each of them "#include iwl-base.c"? Please don't hesitate to share > if you have better ideas. I thought that's what you do now? I haven't looked into what the differences are. Some things I plain don't understand, like this: #if IWL == 4965 #ifdef CONFIG_IWLWIFI_SENSITIVITY why not just make the latter depend on 4965 in Kconfig? Same with HT. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
