Search Linux Wireless

Re: [PATCH 08/15] cfg80211: clean up key add/remove interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Berg wrote:
On Fri, 2007-08-24 at 13:55 -0500, Larry Finger wrote:
Johannes Berg wrote:

I found a compile problem when all the patches were installed in that 'ops' was not defined in wireless/core.c. This patch should be

+       WARN_ON(!drv->ops->add_key && drv->ops->del_key);
+       WARN_ON(drv->ops->add_key && !drv->ops->del_key);

and not WARN_ON(!ops->add_key etc.

I'm pretty sure this is correct since the wiphy_new prototype is

| struct wiphy *wiphy_new(struct cfg80211_ops *ops, int sizeof_priv)

and this is added to wiphy_new. Did the code somehow end up in the wrong
place for you?

johannes

I have been working from the 'b43' branch with a top commit hash of 43a9a146a1290808519c68615809ae8bc207e8a1. It seems to be out of synch with branch 'everything' in this area.

Sorry for the noise.

Larry
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux