Search Linux Wireless

Re: [PATCH 05/15] mac80211: remove HW_KEY_IDX_INVALID

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2007-08-24 at 14:33 -0500, Larry Finger wrote:

> This patch breaks software encryption in my tests - WPA for b43, WPA and WEP for b43legacy. I 
> haven't looked for the cause yet. That is my next step.

The patch below appears necessary for b43 when I enable sw crypto, but
you shouldn't be having such problems in b43legacy since you don't
support crypto at all; or have you not removed the crypto related code
from xmit.c?

johannes

---
 net/mac80211/tx.c |    9 +++++++++
 1 file changed, 9 insertions(+)

--- wireless-dev.orig/net/mac80211/tx.c	2007-08-27 12:06:10.844650841 +0200
+++ wireless-dev/net/mac80211/tx.c	2007-08-27 12:12:46.094650841 +0200
@@ -722,6 +722,15 @@ ieee80211_tx_h_misc(struct ieee80211_txr
 		}
 	}
 
+	/*
+	 * Tell hardware to not encrypt when we had sw crypto.
+	 * Because we use the same flag to internally indicate that
+	 * no encryption should be done, we have to set it after all
+	 * crypto handlers to indicate that we want encryption.
+	 */
+	if (tx->key && !(tx->key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE))
+		tx->u.tx.control->flags |= IEEE80211_TXCTL_DO_NOT_ENCRYPT;
+
 	return TXRX_CONTINUE;
 }
 


-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux