On Wednesday 22 August 2007, Johannes Berg wrote: > On Tue, 2007-08-21 at 23:07 +0200, Ivo van Doorn wrote: > > > Do we need another flag to indicate ICV errors? > > rt2x00 has the following fields to indicate problems during hardware decryption: > > ICV error -> How to report this to mac80211? > > MIC error -> The RX_FLAG_MMIC_ERROR flag can be set > > invalid key -> Could best be done by just not setting RX_FLAG_DECRYPTED I assume. > > I think you either just drop the packet or give it to mac80211 decrypted > but with ICV still on so that mac80211 will verify the ICV (again) and > do whatever is appropriate. But I think dropping it ought to be fine. Do > we want this for monitoring maybe? Not sure how interesting a frame with a ICV error will be, on the other hand I am not even sure how a frame with a ICV error looks like in rt2x00, discovering that will probably happen during the hardware encryption implementation. ;) Ivo - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html