On Tuesday 14 August 2007, Johannes Berg wrote: > On Mon, 2007-08-13 at 08:44 -0700, Michael Wu wrote: > > On Monday 13 August 2007 00:45, Johannes Berg wrote: > > > Oh and somebody needs to fix zd1211rw-mac80211. It abused the > > > MGMT interface constant that was explicitly mentioned to be > > > not for drivers... I've "fixed" it for now but readers of the > > > code may not be happy with it. > > > I've done this in all my drivers. It's perfectly fine. If you're going to drop > > the MGMT enum, please post a patch to s/IEEE80211_IF_TYPE_MGMT/-1/ for all > > drivers. > > Oh, I thought zd1211 was the only one doing that. I could add a > IF_TYPE_INVALID if you really require that, but I don't see the point. > As soon as the driver wants to work with multiple interfaces this stuff > has to go anyway. Also rt2x00 was using IEEE80211_IF_TYPE_MGMT as value to indicate no interface has been configured. So if you are going to run s/IEEE80211_IF_TYPE_MGMT/-1/ please include rt2x00.h in that run too. Thanks :) Ivo - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
