On Mon, Aug 13, 2007 at 02:02:27AM +0200, Michael Buesch wrote:
> On Monday 13 August 2007 01:50:58 Aurelien Jarno wrote:
> > The patch below fixes a warning spotted a few days ago by Andrew Morton
> > while releasing 2.6.23-rc2-mm1.
> >
> > Signed-off-by: Aurelien Jarno <aurelien@xxxxxxxxxxx>
> >
> > --- a/drivers/ssb/driver_pcicore.c
> > +++ b/drivers/ssb/driver_pcicore.c
> > @@ -278,7 +278,7 @@
> > static struct resource ssb_pcicore_mem_resource = {
> > .name = "SSB PCIcore external memory",
> > .start = SSB_PCI_DMA,
> > - .end = SSB_PCI_DMA + SSB_PCI_DMA_SZ - 1,
> > + .end = (u32)SSB_PCI_DMA + (u32)SSB_PCI_DMA_SZ - 1,
> > .flags = IORESOURCE_MEM,
> > };
> >
> >
>
> These casts were intentionally removed by me.
> I think they are bogus and I have no idea why this
> generates this strange compiler warning (I think it
> was some overflow warning?).
>
Yes it is overflow warning. The compiler thinks that those constant are
signed values and thus generate an overflow.
Another fix would be to postfix those constants by U.
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@xxxxxxxxxx | aurelien@xxxxxxxxxxx
`- people.debian.org/~aurel32 | www.aurel32.net
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
