Search Linux Wireless

[PATCH] hostapd: don't reference ieee80211_msg_sta_not_assoc if it's unused anyway

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hostapd doesn't do anything about such frames. Kernel no longer sends
them and the constant was removed, so let's not reference it any longer.


Signed-off-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>

--- hostap.orig/hostapd/driver_devicescape.c	2007-08-10 23:33:19.000000000 +0200
+++ hostap/hostapd/driver_devicescape.c	2007-08-10 23:35:10.000000000 +0200
@@ -1351,9 +1351,12 @@ static void handle_frame(struct hostapd_
 	}
 
 	/* PS-Poll frame from not associated is 16 bytes. All other frames
-	 * passed to hostapd are 24 bytes or longer. */
-	if (len < 24 &&
-	    (msg_type != ieee80211_msg_sta_not_assoc || len < 16)) {
+	 * passed to hostapd are 24 bytes or longer.
+	 * Right now, the kernel doesn't send us any frames from not-associated
+	 * because the code here doesn't care. TODO: add support to kernel
+	 * and send DEAUTH/DISASSOC to them...
+	 */
+	if (len < 24) {
 		printf("handle_frame: too short (%lu), type %d\n",
 		       (unsigned long) len, msg_type);
 		return;
@@ -1425,9 +1428,15 @@ static void handle_frame(struct hostapd_
 	case ieee80211_msg_michael_mic_failure:
 		hostapd_michael_mic_failure(hapd, buf, data_len);
 		return;
-	case ieee80211_msg_sta_not_assoc:
-		/* TODO: ieee802_11_rx_sta_not_assoc(hapd, buf, data_len); */
+/*
+ * TODO
+ * We should be telling them to go away. But we don't support that now.
+ * See also below and above for other TODO items related to this.
+
+ 	case ieee80211_msg_sta_not_assoc:
+		ieee802_11_rx_sta_not_assoc(hapd, buf, data_len);
 		return;
+ */
 	default:
 		printf("handle_frame: unknown msg_type %d\n", msg_type);
 		return;


-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux