On Wed, 2007-08-08 at 11:34 +0200, Johannes Berg wrote: > On Wed, 2007-08-08 at 00:56 -0700, Michael Wu wrote: > > On Tuesday 07 August 2007 13:33, John W. Linville wrote: > > > The ternary conditionals are a bit ugly. I guess I could recode it > > > with temp vars initialized before calling ieee80211_sta_start_scan. > > > > > Something more like: > > > > if (ifsta->auto_ssid_sel && ifsta->ssid_len) > > ieee80211_sta_start_scan(dev, NULL, 0); > > else > > ieee80211_sta_start_scan(dev, ifsta->ssid, ifsta->ssid_len); > > Except you got the condition inverted. Well, not fully inverted. Shouldn't it be if (!ifsta->auto_ssid_sel && ifsta->ssid_len) ...(dev, ifsta->ssid, ifsta->ssid_len) else ...(dev, NULL, 0) On the other hand, calling with a "anything, 0" probably has the same effect as calling with "NULL, 0" so the "ifsta->ssid_len" condition can go away just as linville had it. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
