On Friday 03 August 2007, Stefano Brivio wrote:
> On Thu, 02 Aug 2007 10:53:17 -0500
> Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote:
>
> > +static char big_buffer[1024*256];
>
> static char big_buffer[1024 * 256];
>
> > + bcmerr(dev->wl, "debugfs: Board not initialized.\n");
> > res = -EFAULT;
> > goto out_unlock;
> > }
> > - if (sscanf(buf, "%lli", &tsf) != 1) {
> > - printk(KERN_INFO PFX "debugfs: invalid values for
> > \"tsf\"\n");
> > + if (sscanf(buf, "%llu", (unsigned long long *)(&tsf)) != 1) {
> > + bcmerr(dev->wl, "debugfs: invalid values for \"tsf\"\n");
>
> "debugfs: Invalid values for TSF.\n"
>
> > + int i;
> > + int idx;
>
> int i, idx;
No, checkpatch complains about multiple variables per line.
> > +void bcm43xx_debugfs_add_device(struct bcm43xx_wldev *dev)
> > {
> > struct bcm43xx_dfsentry *e;
> > - char devdir[IFNAMSIZ];
> > + struct bcm43xx_txstatus_log *log;
> > + char devdir[16];
> >
> > - assert(bcm);
> > + BCM43xx_BUG_ON(!dev);
> > e = kzalloc(sizeof(*e), GFP_KERNEL);
> > if (!e) {
> > - printk(KERN_ERR PFX "out of memory\n");
> > + bcmerr(dev->wl, "debugfs: add device OOM\n");
>
> "debugfs: OOM while adding device.\n"
>
> > + bcmerr(dev->wl, "debugfs: add device txstatus OOM\n");
>
> "debugfs: OOM while adding device txstatus.\n"
>
> And the same for all the debugfs messages, please be consistent.
>
>
All your comments address code that's not written my larry, but me.
So if you want that fixed, please send patches.
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
