On Thursday 02 August 2007, Larry Finger wrote: > Michael Buesch wrote: > > On Thursday 02 August 2007, Larry Finger wrote: > >> Michael, > >> > >> I couldn't find any long/short indication in the header, so I added a bool that > >> is set when the frame is sent. > > > > This is not going to work. > > > > But we can do this differently. > > You can do something like: > > > > if (!status->acked && !tx_control->noack) > > excessive_retries = 1; > > > > So we don't need to care about the retry count. > > > > Anyway. I don't know why we need excessive_retries _at_ _all_. > > The rc algorithm does already know if the frame succeed or failed > > anyway. > > Is this what you had in mind? > > Larry > > > @@ -1311,6 +1311,9 @@ void bcm43xx_dma_handle_txstatus(struct > */ > if (status->acked) > meta->txstat.flags |= IEEE80211_TX_STATUS_ACK; > + else > + if (!(meta->txstat.flags & IEEE80211_TXCTL_NO_ACK)) > + meta->txstat.excessive_retries = 1; > meta->txstat.retry_count = status->frame_count - 1; > ieee80211_tx_status_irqsafe(dev->wl->hw, meta->skb, &(meta->txstat)); > /* skb is freed by ieee80211_tx_status_irqsafe() */ Yeah, looks good. If you correctly diff that up, I'll queue it up for the next submission to John. - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
