A typo in the specs interchanges the branches in an if statement, which breaks operations for a BCM4306/rev 2 that has phy->analog == 1. Signed-off-by: Larry Finger<Larry.Finger@xxxxxxxxxxxx> --- John and Michael, This patch is made for the wireless-dev tree after the bcm43xx-mac80211 directory has been moved into drivers/net/wireless, but it needs to be applied to the wireless-mb tree as well. Larry Index: wireless-dev/drivers/net/wireless/bcm43xx-mac80211/bcm43xx_phy.c =================================================================== --- wireless-dev/net/wireless/bcm43xx-mac80211/bcm43xx_phy.c +++ wireless-dev/drivers/net/wireless/bcm43xx-mac80211/bcm43xx_phy.c @@ -1895,7 +1895,7 @@ void bcm43xx_phy_set_baseband_attenuatio bcm43xx_write16(dev, BCM43xx_MMIO_PHY0, (bcm43xx_read16(dev, BCM43xx_MMIO_PHY0) & 0xFFF0) | baseband_attenuation); - } else if (phy->analog == 1) { + } else if (phy->analog != 1) { bcm43xx_phy_write(dev, BCM43xx_PHY_DACCTL, (bcm43xx_phy_read(dev, BCM43xx_PHY_DACCTL) & 0xFFC3) | (baseband_attenuation << 2)); - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html