On Thu, Jul 19, 2007 at 10:27:16PM -0700, Pete Zaitcev wrote: > On Wed, 18 Jul 2007 00:48:31 -0700, Michael Wu <flamingice@xxxxxxxxxxxx> wrote: > > > On Monday 16 July 2007 23:10, Pete Zaitcev wrote: > > > + if ((err = p54u_bulk_msg(priv, P54U_PIPE_DATA, buf, 4)) != 0) { > > Please follow the style used elsewhere in this function and do it like: > > > > err = p54u_bulk_msg(priv, P54U_PIPE_DATA, buf, 4); > > if (err) { > > > > The rest of the patch looks fine. Thanks for fixing this. > > How about this, then? <snip> That is exactly the way I committed it. Thanks, Pete! John -- John W. Linville linville@xxxxxxxxxxxxx - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html