Search Linux Wireless

Re: [PATCH 1/2] zd1211rw-mac80211: return hardware specific tx rate code for rx status

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07-07-19 15:10 John W. Linville wrote:

> On Mon, Jun 11, 2007 at 11:38:29AM +0100, andy@xxxxxxxxxxx wrote:
> > zd1211rw-mac80211 uses different hardware-specific codings to talk about
> > rates when doing transmit and receive.  Because mac80211 looks up the rx
> > rate against the rates table used for selecting hardware-specific coding for
> > tx, the rate returned in the rx_status struct needs to be adjusted to use the
> > coding used to hardware-specific tx rates.  This patch performs this adjustment.
> > 
> > Without this patch the radiotap-based monitor stuff reports a "0.0Mbps" rate for
> > all packets from this driver.
> > 
> > CC: Daniel Drake <dsd@xxxxxxxxxx>
> > CC: Ulrich Kunitz <kune@xxxxxxxxxxxxxx>
> > Signed-off-by: Andy Green <andy@xxxxxxxxxxx>
> 
> Daniel, Uli -- ack/nak?

John,

NAK. The patch introduces unnecessarily a new function.

I have already the correct patch in the queue:

http://deine-taler.de/git-bin/gitweb.cgi?p=zd1211rw.git;a=commitdiff;h=d635ff55fa76ff36da0b923c680861ccbddf34ad;hp=7e052f8d9f078314f3a3ad4a052e9a6c0e8fcadb

Kind regards,

Uli

-- 
Uli Kunitz
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux