Search Linux Wireless

Re: [PATCH] mac80211: separate monitor/subif_start_xmit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 28 June 2007 22:39, Michael Wu wrote:
> On Thursday 28 June 2007 22:35, Michael Wu wrote:
> > On Thursday 21 June 2007 06:39, Johannes Berg wrote:
> > > +	skb_set_network_header(skb, len + sizeof(struct ieee80211_hdr));
> > > +	skb_set_transport_header(skb, len + sizeof(struct ieee80211_hdr));
> > > +
> >
> > Hm, just noticed a potential problem with this. sizeof(struct
> > ieee80211_hdr) can't be used since ieee80211 headers are variable sized
> > and the smallest frames can end up being smaller than the 4 addr header.
>
> And the other code in subif_xmit does this too.. hrm.
>
Uh, nevermind, the subif_start_xmit code is fine. Read the wrong part..

-Michael Wu

Attachment: pgp01eFQVmAhe.pgp
Description: PGP signature


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux