Search Linux Wireless

Re: [patch 3/5] A-MSDU Rx aggregation support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mohamed,

> +		padding = calc_pad_len(subframe_len);
> +		/* the last MSDU has no padding */
> +		if (subframe_len > remaining)
> +			return TXRX_DROP;
> +
> +		frame = dev_alloc_skb(local->hw.extra_tx_headroom + 
> +				      subframe_len);
> +
> +		if (frame == NULL) 
> +			return TXRX_DROP;
> +
> +		memcpy(skb_put(frame, subframe_len), (u8*)eth, subframe_len);
> +		frame->mac.raw = frame->data;
> +		skb2 = NULL;

Here you allocate a new frame which can be sent back to the device when
one of the aggregated frames was a multicast frame and we're an AP
device. You also correctly add extra_tx_headroom, but it seems that this
is missing some skb_reserve(extra_tx_headroom), no? Could you make a
patch adding it? I'm not sure I fully understand the code there.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux