On Tuesday 19 June 2007 20:03, Hong Liu wrote:
> + struct ieee80211_hw_mode *mode = NULL;
> + int c = 0;
> +
Shouldn't add an extra empty line here.
> + if (chan->flag & IEEE80211_CHAN_W_SCAN) {
> + range->freq[c].i = chan->chan;
> + range->freq[c].m = chan->freq * 100000;
> + range->freq[c].e = 1;
> + }
> + ++j; ++c;
c shouldn't be incremented if the channel is being skipped.
Also, two minor comments on the style since this patch needs to be revised
anyway - using ++x instead of x++ looks a bit odd, and using 'int j'
when 'int i' is available is also a little strange.
Patch looks good otherwise.
-Michael Wu
Attachment:
pgpC6QPRKapT9.pgp
Description: PGP signature
