On Thu, Jun 14, 2007 at 04:08:44PM -0400, John W. Linville wrote: > On Thu, Jun 14, 2007 at 12:56:18PM -0700, Andrew Morton wrote: > > On Thu, 14 Jun 2007 15:09:36 -0400 > > "John W. Linville" <linville@xxxxxxxxxxxxx> wrote: > > > > > It does not make sense to me to rip this out purely for aesthetic > > > reasons. > > > > Aesthetics are good, but that's not the main issue. > > > > What is most worrying is that there appears to be a risk that these > > newly-added interfaces will later become obsoleted by another interface. > > This means that we'll need to maintain, test and support _both_ interfaces > > for a very long time. This is the sort of foot-shooting we should avoid. > > True enough. However, I hope you will agree that we should not > confuse foresight with speculation. > > At present there is no sign on the horizon of either any mac80211 > mesh code or any other full-MAC wireless driver supporting mesh. > Without either of those, it would seem imprudent to rush toward > a gneric configuration interface even if nl80211 was prepared to > sprout one. Making it generic may be premature optimization. But at the very least, we should deal with the three other problems Christoph has pointed out: subfunctions, pointer indirections, and 32on64 cleanliness. That last one may come back to bite you in a couple years' time, if not other people. It's a major pain in the ass. -- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html