On Tuesday 12 June 2007 02:55, andy@xxxxxxxxxxx wrote:
> + /* see if this argument is something we can use */
> + switch (iterator.this_arg_index) {
I suggest also handling flags and checking for the FCS bit. (and strip the
last four bytes of the skb if it is present) That should make it possible to
directly inject any captured frames.
> + /* end on exact match */
> + if (r->rate == target_rate)
> + i = mode->num_rates;
> +
Unnecessary blank line.
These patches should be pretty good now. I suggest CCing John Linville,
Johannes Berg, and Jiri Benc on the next series. I'd like to get these
patches in soon if there are no other issues. 12 tries should be enough to
get this right. ;)
Thanks,
-Michael Wu
Attachment:
pgpt6cha2JEDy.pgp
Description: PGP signature
