On 6/11/07, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
Hi Yi, In sta_process_dls_req, you currently always accept DLS. I'm not sure how well power save mode works in mac80211 (probably not at all, someone versed in 802.11 should probably look at it some time soon), but once DLS is set up power saving must be disabled by the DLS peer. This, however, possibly leads to battery lifetime diminishing, so always accepting the direct link might not be desirable. Any thoughts?
This is correct that power save must be disabled explicitly in this implementation. Usually you want to establish DLS for increasing throughput so you won't go to power save mode anyway. One other thing is encryption, the path for peer key handshake must be opened in mac80211 in addition to this patch.
Should we have user-space controlled list of DLS possible DLS peers? Or call out to userspace via nl80211 to make a decision? The list would be easy by simply adding a sta_info for a possible DLS peer, callout also shouldn't be too hard by sending a message to some QoS nl80211 multicast group and possibly not responding to the DLS request at all when our userspace doesn't accept it (that way it'll just time out on the other side). johannes
- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
