Hi Andy,
Thanks for the repost.
> +/* Radiotap header iteration
> + * implemented in net/wireless/radiotap.c
> + *
> + * call __ieee80211_radiotap_iterator_init() to init a semi-opaque iterator
> + * struct ieee80211_radiotap_iterator (no need to init the struct beforehand)
> + * then loop calling __ieee80211_radiotap_iterator_next()... it returns -1
> + * if there are no more args in the header, or the next argument type index
> + * that is present. The iterator's this_arg member points to the start of the
> + * argument associated with the current argument index that is present,
> + * which can be found in the iterator's this_arg_index member. This arg
> + * index corresponds to the IEEE80211_RADIOTAP_... defines.
> + */
I don't think this will show up in the kdoc output, but it sure would be
nice. Maybe it could be part of the description of
ieee80211_radiotap_iterator as a 'how to use this iterator' section (see
kernel-doc-nano-HOWTO.txt, it talks about sections)? Or maybe as
kernel-doc for the functions themselves.
> +/**
> + * ieee80211_radiotap_iterator_init - radiotap parser iterator initialization
Oh, you have kerneldoc comments in the source file. Does anyone know
which is preferable? I usually put everything into the header file that
is not implementation-detail.
> + * no need to check again for blowing past stated radiotap
> + * header length, becuase ieee80211_radiotap_iterator_next
^^^^^^^
typo
> + * care of alignment handling and extended present fields. interator->this_arg
typo: "interator", also I don't understand why you would want to change
this_arg?
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
