On Mon, 2007-06-11 at 10:57 +0800, Zhu Yi wrote: > When I sent the patch the first time which used sysfs, the comment was > one value per file (Is this still true for debugfs?). Hah, yeah, that's the regular rule for sysfs, but debugfs basically has no rules ;) > The DLS is easier because it only has one parameter (peer mac address) > now. I programed it the same way as tspec. So when we find to need more > parameters for DLS setup, we can add another debugfs file for the new > parameter instead of combining multiple parameters in one file. Alright. I don't think it matters much anyway. > I'd agree I didn't pay a lot of attentions to the debugfs interface > design since I thought it was used for occasional debug only. Please > tell me what which do you prefer: one value per file or multiple values > per file so that we can do one shot parameter passing? So I don't need > to switch them back and forth. No, don't bother, too much work for too little gain. Maybe gather some thoughts on the nl80211 interface instead :) I personally prefer one-shot parameter passing because it's closer to what we'll be doing with nl80211 so we can model the interface like nl80211, however, the interface between the debugfs and the regular mac80211 code could still be modelled after nl80211 (it could even call some cfg80211 stuff when that's added) johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
