On Fri, 08 Jun 2007 09:34:37 +0800, Zhu Yi wrote: > On Thu, 2007-06-07 at 22:30 +0200, Jiri Benc wrote: > > > +#define SET_TSINFO_SCHEDULE(i, d) (i.byte3 |= (d << 0) & 0x01) > > > > Please add IEEE80211_ prefix here as well. For consistency and not > > polluting a name space. > > Point accepted. Thanks :-) > I think we have talked this early and now you know correctly WIFI is not > a trademark. You define IEEE80211_STYPE_ASSOC_REQ, etc, but defines > those for Wi-Fi with WLAN prefix? WLAN prefix should be used by symbols > defined by mac80211, for example: WLAN_CAPABILITY_ESS. You and Jouni are right, WLAN_ is used for IEEE 802.11 stuff. So another prefix makes sense here. And I realized my other comment wasn't meaningful too, as also IEEE 802.11 is a trademark. ACK for those names, thanks for the clarification. Jiri -- Jiri Benc SUSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
