Search Linux Wireless

Re: [PATCH] softmac: use list_for_each_entry

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes,

Johannes Berg wrote:
On Sun, 2007-05-27 at 23:27 +0900, Akinobu Mita wrote:
Cleanup using list_for_each_entry.

This patch adds missing NULL check and trims a line longer than 80
columns.

Both patches look good to me but I do wonder why you're actually looking
at this code :)

I sure hope somebody will port bcm43xx driver to mac80211 (again) soon
so we can remove softmac.

As it is impossible to predict how long until we can remove softmac, such patches should be accepted. You understand that I'm not looking for problems in softmac.

As we discussed earlier, bcm43xx-softmac has to be ported to mac80211 to support 802.11b-only cards, as the V4 firmware does not accommodate them. I had started this project by changing the namespace to bcm4301. That patch went into Linville's wireless-dev pending list. I then started learning the interface to mac80211. For a number of reasons, that step was going slowly. Michael Wu recently offered to take over, which seemed reasonable given his familiarity with mac80211.

When Michael Wu gets a version of bcm4301-mac80211 that compiles cleanly, I will be testing it as he doesn't have the hardware. For my testing purposes, the 802.11g stuff will still be there. Once I get it working, I plan to post a patch to get as much testing as possible.

In the earlier discussion, we also concluded that the product of a conversion from softmac to mac80211 should not be included in mainline, with the exception of the b-only code. Depending on how long the port and testing take, and the state of bcm43xx-mac80211 at that time, a reversal of that earlier decision may be in order.

Larry
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux