Jeff Garzik wrote:
As an aside #2,
+#if IWL == 4965
+ (rxon1->ofdm_ht_single_stream_basic_rates ==
+ rxon2->ofdm_ht_single_stream_basic_rates) &&
+ (rxon1->ofdm_ht_dual_stream_basic_rates ==
+ rxon2->ofdm_ht_dual_stream_basic_rates) &&
+ (rxon1->rx_chain == rxon2->rx_chain) &&
+#endif
those #if's should go away.
Agreed. We'll continue working to remove those over time.
Originally the intent was to have a single driver that supported the 4965 and 3945 via run-time switching. As development moved forward, switching to a build-time approach made more sense. base.c was then isolated from the hardware specific code and the specific HW functionality was moved into iwl-3945 and iwl-4965. The remaining chunks are small code pieces where that work hasn't yet completed.
James
Jeff
-
To unsubscribe from this list: send the line "unsubscribe
linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
