On Monday 07 May 2007 11:25, Jeff Garzik wrote: > I am a bit skeptical that multiple files are needed. It seems like > drivers/net/wireless/rtl818x.c would be a better path, a la tg3.c. > The radio tuning stuff could be stuffed into rtl8187_dev.c, but I like to keep it separate since rtl8187_rtl8225.c tends to contain all the radio tuning black magic that no one really understands except for the engineers at Realtek, whereas rtl8187_dev.c is mostly straightforward. rtl8187 can also (in theory) use another radio chip (rtl8255). The two headers - rtl818x.h and rtl8187.h cannot be merged because the definitions in rtl818x.h are shared between the usb and pci drivers. I rather not combine any files, though I don't mind collapsing the driver another level. However, I think other driver authors much prefer having their own directory, and I'd like to keep the drivers consistently in their own directory or all together in drivers/net/wireless. -Michael Wu
Attachment:
pgpKx9yxPdy8o.pgp
Description: PGP signature
