Search Linux Wireless

Re: [PATCH 3/4] mac80211: document requirement for atomicity of callbacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 29 Apr 2007 11:15:43 +0200, Michael Buesch wrote:
> On Sunday 29 April 2007 02:33:45 Jiri Benc wrote:
> > +	 * Must be atomic. */
> >  	int (*set_key)(struct ieee80211_hw *hw, set_key_cmd cmd,
> >  		       u8 *addr, struct ieee80211_key_conf *key, int aid);
> 
> I think USB drivers and bcm43xx violate that. We can't easily workaround it
> without doing the operation async.

I know. Unfortunately, it's not easy to fix that in mac80211. I really want
this call not to be atomic and will try to change it later, but it's not a
priority now.

For now, just always return success and complain to dmesg if something goes
wrong during setting of the key in a workqueue.

Thanks,

 Jiri

-- 
Jiri Benc
SUSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux