Search Linux Wireless

Re: [PATCH] bcm43xx-mac80211: Make wireless statistics yield reasonable values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Michael Wu wrote:
On Sunday 15 April 2007 00:22, Larry Finger wrote:
-	hw->max_rssi = -110;
-	hw->max_signal = BCM43xx_RX_MAX_SSI;
+	hw->max_signal = 100; /* This looks wrong, but is what mac80211 wants */
+	hw->max_rssi = BCM43xx_RX_MAX_SSI;
The number being passed into ssi is dBm, so why is the max being set to 60? It should be set to the minimum dBm that the device can report, like -110 as it was set before. Since SSI is actually being passed into signal, MAX_SSI should go to max_signal.

You are correct that -110 would be better than -196, which is what 60 translates to given the s8 arithmetic. Due to the internal workings of mac80211, the quantity in max_signal ends up as the denominator in the qual report of x/y. I would sooner give the users a percentage that parts per 60.

Larry
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux