On Thu, 2007-03-29 at 14:31 +0100, andy@xxxxxxxxxxx wrote: > plain text document attachment > (mac80211-sparse-annotate-radiotap-header-pavel-roskin.diff) > Document that all fields must be little endian. Use annotated types > even in the comments. Consistently use shorter type names (u8, s8). > Realign the comments. I don't know what it means, but I think wireless-dev should just copy include/net/ieee80211_radiotap.h from wireless-2.6. The later has more fields, and it turns out they are approved by David Young, the radiotap maintainer. There is no reason mac80211 would need to change that file. > * > - * IEEE80211_RADIOTAP_FCS u32 data > + * IEEE80211_RADIOTAP_FCS __le32 data > * > * FCS from frame in network byte order. I sent a patch yesterday that removes this part altogether. I'm fine with this patch, I'm just saying that adjusting the patch is more work than copying the file. -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
