On Wed, 2007-03-28 at 23:08 +0200, Michael Buesch wrote:
> On Wednesday 28 March 2007 20:23, Johannes Berg wrote:
> > > + while ((u8*)eth < skb->data + skb->len) {
> >
> > I don't understand this cast of eth to u8*. That seems wrong given that
> > there's an ethhdr there where the first byte isn't a length byte.
>
> We're not comparing the data eth points to here, but the eth pointer
> itself. It's pretty weird code. Maybe this can be solved in a
> more clear way. But it might be correct as-is.
Yeah, I read it wrong. It's fine, see my new mail.
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
