On Wed, 2007-03-28 at 11:14 +0200, Johannes Berg wrote: > On Mon, 2007-03-26 at 04:38 -0700, mohamed wrote: > > > + /* Get ht capabilities from the device */ > > + int (*get_ht_capab)(struct ieee80211_hw *hw, > > + struct ieee80211_ht_capability *ht_cap_param); > > + > > Does this really need to return an error? And if so, what happens? You > currently send a blank HT capabilities IE but I think in that case it > should be left out completely. But I don't think it will ever return an > error, it doesn't even need to allocate memory. Just change this to > void? > > johannes Since we are setting the structure to all 0 before calling the function I guess it is safe to change the function to return void. I will resubmit the patch with that fix Mohamed - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html