On Wednesday 21 March 2007 14:51, Johannes Berg wrote:
> > + /* Driver supports radiotap. */
> > +#define IEEE80211_HW_RADIOTAP_SUPPORTED (1<<10)
> >
> > + if (local->monitors &&
> > + local->hw.flags & IEEE80211_HW_RADIOTAP_SUPPORTED) {
> > + radiotap_len = ieee80211_get_radiotap_len(skb);
> > + skb_pull(skb, radiotap_len);
> > + }
>
> I don't think that can work.
>
> 1) it needs a lot more documentation on what a driver needs to do for
> this (for example that it should only add radiotap headers if a
> monitor interface was added)
>
Lack of documentation makes code not work?
> 2) afaik local->monitors is increased even for soft monitor interfaces,
> thus this will really fall on its nose when the driver supports
> radiotap but not monitor during operation.
>
Yes. I noted that in December when the patch was first posted. This will be
fixed when I post a radiotap RX patch that's actually signed off. No sign off
from me means it's not done and probably not tested enough if at all.
-Michael Wu
Attachment:
pgpItdtk7IlBf.pgp
Description: PGP signature
