On Wednesday 21 March 2007 16:29, Larry Finger wrote: > Michael Buesch wrote: > > On Tuesday 20 March 2007 21:49, Larry Finger wrote: > >> The code in the mac80211 version of radio_init2050 differs from the specs > >> in two places. > >> > >> Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> > >> --- > >> > >> Index: wireless-mb/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c > >> =================================================================== > >> --- wireless-mb.orig/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c > >> +++ wireless-mb/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c > >> @@ -3444,9 +3444,9 @@ static u16 radio2050_rfover_val(struct b > >> if (phy_register == BCM43xx_PHY_RFOVER) { > >> return 0x9B3; > >> } else if (phy_register == BCM43xx_PHY_RFOVERVAL) { > >> - extlna |= (i << 8); > >> if (extlna) > >> extlna |= 0x8000; > >> + extlna |= (i << 8); > > > > What's the difference? > > The nonzero test for extlna should be made on the table value, not the table value or'd with i << 8. Oh, I see. Some brain screwage on my side :) -- Greetings Michael. - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html