On Monday 19 March 2007 06:54, Andy Green wrote: > Michael Wu wrote: > > I've mostly made comments about style issues. There are only comments on > > the first instance of any style problem so please check the rest of the > > code for the same problems. > > Thanks for this feedback Michael. I have changed all the style problems > my eyes could see, assisted by visiting every = in the patch. > Just one last thing.. a bunch of the comments in the last chunk of the patch are still indented too much. Otherwise, the 4th version of the patch looks good as far as style goes. > > Have you looked into padding issues with radiotap headers? For example, > > if there is a 1 byte field which is then followed by a 4 byte field, > > there needs to be 3 bytes of padding after the first field, but if the > > field after were 2 bytes long, the padding would only be 1 byte > > (according to my understanding of the radiotap specs). > > I googled for radiotap specs but I didn't find anything useful. I added > some small code to enforce the alignment rules you mention above. > I got the information on padding from: http://madwifi.org/wiki/DevDocs/RadiotapHeader I don't remember how I managed to find that, but there it is. Thanks, -Michael Wu
Attachment:
pgpomB31WxrS2.pgp
Description: PGP signature
