Search Linux Wireless

Re: [PATCH 2/2] mac80211: Monitor mode radiotap-based packet injection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Saturday 17 March 2007 18:09, Andy Green wrote:
> Yeah naturally it was my first move to use what was there, but the
> result was a panic that went away when I moved the skb to belong to the
> "master" interface's index and separately persistently tagged the packet
> as being injected.
>
I don't see anything that would prevent this from working.. if you have a 
patch which does this and crashes, I'll take a look at it.

> Is it safe against race problems on interface removal to consider to
> look up against the interface index at actual send time?
>
Yes. dev_get_by_index in ieee80211_master_start_xmit calls dev_hold. When it 
is done, dev_put is called. The headroom reservation code looks suspicious 
though.. it doesn't call dev_put if it fails. Fortunately, this is unlikely 
to happen.

Thanks,
-Michael Wu

Attachment: pgpGebvvKOqwj.pgp
Description: PGP signature


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux