On Saturday 17 March 2007 02:15, Paul TBBle Hampson wrote: > ] rmmod prism54 > Mar 17 16:43:26 su kernel: prism54-0: removing device > Mar 17 16:43:26 su kernel: Unloaded prism54 driver > > Then, with the p54 code, patched with the patch you attached. > > ] modprobe prism54pci > Mar 17 16:48:56 su kernel: p54: LM86 firmware > Mar 17 16:48:58 su kernel: 0001:11:00.0 (prism54pci): Cannot read eeprom! > Mar 17 16:48:58 su kernel: prism54pci: probe of 0001:11:00.0 failed with > error -22 > > Hmm, I guess the patch fixed the BUG_ON. ^_^ > Ok good, thanks for testing! > Still fails to read an eeprom from my card though. I'm wondering if the > crapspew from the prism54 driver implies card or socket badness? > These devices do go bad, so a broken card isn't out of the question. However.. > However, the hardmac driver is able to get a MAC address (with an OID > query, according to the code) and the MAC address is correct: > 00:60:64:03:41:81 > My broken card never got that far. > Is it worth dumping the purported eeprom to see if it's actually a valid > eeprom in a format unexpected by the code? (The card is very old now...) > Actually, the code doesn't check (but it does report) if parsing fails so a corrupted eeprom can't be the reason for probe failure. I'll get that fixed next week.. So anyway, your card isn't even returning the eeprom data. Only thing I can think of is fiddling with the mdelay in that (p54p_read_eeprom) function (there's only one). Try making it bigger. That mdelay solved problems with eeprom reading on module reload but it's very close to the minimum delay needed there. -Michael Wu
Attachment:
pgpxWFMEdJPPb.pgp
Description: PGP signature