On Saturday 17 March 2007 00:38, Dan Williams wrote: > On Fri, 2007-03-16 at 23:57 -0400, Michael Wu wrote: > > On Friday 16 March 2007 23:46, Dan Williams wrote: > > > I think you're misreading the patch? It looks correct to me. The > > > second check for (erq->flags & IW_ENCODE_RESTRICTED) should ensure that > > > Shared Key is only selected when the userspace program requested it. > > > > This breaks authentication algorithm fallback for sure. > > Well, then it's broken in most of the non mac80211 drivers then. > Why is that? The reason this breaks mac80211 is because auth_algs is a bitfield which indicates what authentication algorithms can be used. This patch makes it so that if a user chooses an authentication algorithm, that is the only one that will ever be used. > Well, if mac80211 can cycle (is this like airo's auto_wep?) then I guess > we don't care about the auth mode. As long as we don't break userspace > programs that try to set the auth mode, I'm fine with that. > mac80211 should just ignore the bits. Airo's auto_wep appears to cycle through different encryption keys while mac80211 does not. -Michael Wu
Attachment:
pgpFghctEOwgj.pgp
Description: PGP signature
