On Thursday 15 March 2007 23:28, Hong Liu wrote: > + if (erq->flags & (IW_ENCODE_OPEN | IW_ENCODE_RESTRICTED)) > + if (sdata->type == IEEE80211_IF_TYPE_STA || > + sdata->type == IEEE80211_IF_TYPE_IBSS) > + sdata->u.sta.auth_algs = > + (erq->flags & IW_ENCODE_RESTRICTED) ? > + IEEE80211_AUTH_ALG_SHARED_KEY : > + IEEE80211_AUTH_ALG_OPEN; > + This is not right because encrypted access points often do not require shared key authentication to associate. In fact, some cannot or refuse to use shared key authentication and your patch prevents retrying with a different authentication algorithm. IW_ENCODE_RESTRICTED simply means that the interface should not make/accept unencrypted connections. In client mode without wpa_supplicant, the AP selection code already refuses to select any APs without encryption enabled if the default key is set. In adhoc mode, there's no such check, but I'm not sure how much it matters. -Michael Wu
Attachment:
pgpQXtxmsd6uH.pgp
Description: PGP signature
