Search Linux Wireless

Re: [PATCH] mac80211: Properly kill tasklets before shutdown

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2007-03-06 at 19:01 +0100, Michael Buesch wrote:

> This fixes the tasklet related crash that was reported some time ago.

I agree with that :)
 
> -	tasklet_disable(&local->tasklet);
> -	/* TODO: skb_queue should be empty here, no need to do anything? */
> +	tasklet_kill(&local->tx_pending_tasklet);
> +	tasklet_kill(&local->tasklet);

But I'm not sure this is sufficient. I think we can then leak pending
skbs. In my tests I've often gotten that warning message about the skb
queue not being empty (right before the crash). Or is that handled
elsewhere now?

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux